Maximum XOR of Two Non-Overlapping Subtrees
Time O(nlogr) · Space O(n) · Official statement on LeetCode
Solutions
// Time: O(nlogr), r is sum(values)
// Space: O(n)
// iterative dfs, trie, greedy
class Solution {
private:
class Trie {
public:
Trie(int bit_length)
: bit_length_(bit_length)
, nodes_(1) {}
void insert(int64_t num) {
int idx = 0;
for (int i = bit_length_ - 1; i >= 0; --i) {
int64_t curr = (num >> i) & 1;
if (!nodes_[idx][curr]) {
nodes_.emplace_back();
nodes_[idx][curr] = size(nodes_) - 1;
}
idx = nodes_[idx][curr];
}
}
int64_t query(int64_t num) {
if (size(nodes_) == 1) {
return -1;
}
int64_t result = 0, idx = 0;
for (int i = bit_length_ - 1; i >= 0; --i) {
int64_t curr = (num >> i) & 1;
if (nodes_[idx][1 ^ curr]) {
idx = nodes_[idx][1 ^ curr];
result |= 1ll << i;
} else {
idx = nodes_[idx][curr];
}
}
return result;
}
private:
const int bit_length_;
vector<array<int, 2>> nodes_;
};
public:
long long maxXor(int n, vector<vector<int>>& edges, vector<int>& values) {
vector<vector<int>> adj(size(values));
for (const auto& e : edges) {
adj[e[0]].emplace_back(e[1]);
adj[e[1]].emplace_back(e[0]);
}
const auto& iter_dfs = [&]() {
vector<int64_t> lookup(size(values));
vector<tuple<int, int, int>> stk = {{1, 0, -1}};
while (!empty(stk)) {
const auto [step, u, p] = stk.back(); stk.pop_back();
if (step == 1) {
stk.emplace_back(2, u, p);
for (const auto& v : adj[u]) {
if (v == p) {
continue;
}
stk.emplace_back(1, v, u);
}
} else if (step == 2) {
lookup[u] = values[u];
for (const auto& v : adj[u]) {
if (v == p) {
continue;
}
lookup[u] += lookup[v];
}
}
}
return lookup;
};
const auto& lookup = iter_dfs();
Trie trie(bit_length(lookup[0]));
const auto& iter_dfs2 = [&]() {
using RET = int64_t;
RET result{0};
vector<tuple<int, int, int, shared_ptr<RET>, RET *>> stk = {{1, 0, -1, nullptr, &result}};
while (!empty(stk)) {
const auto [step, u, p, new_ret, ret] = stk.back(); stk.pop_back();
if (step == 1) {
*ret = max(*ret, trie.query(lookup[u]));
stk.emplace_back(3, u, p, new_ret, ret);
for (const auto& v : adj[u]) {
if (v == p) {
continue;
}
const auto& new_ret = make_shared<RET>(0);
stk.emplace_back(2, v, u, new_ret, ret);
stk.emplace_back(1, v, u, nullptr, new_ret.get());
}
} else if (step == 2) {
*ret = max(*ret, *new_ret);
} else if (step == 3) {
trie.insert(lookup[u]);
}
}
return result;
};
return iter_dfs2();
}
private:
int bit_length(int64_t x) {
return x != 0 ? 64 - __builtin_clzll(x) : 1;
}
};
// Time: O(nlogr), r is sum(values)
// Space: O(n)
// dfs, trie, greedy
class Solution2 {
private:
class Trie {
public:
Trie(int bit_length)
: bit_length_(bit_length)
, nodes_(1) {}
void insert(int64_t num) {
int idx = 0;
for (int i = bit_length_ - 1; i >= 0; --i) {
int64_t curr = (num >> i) & 1;
if (!nodes_[idx][curr]) {
nodes_.emplace_back();
nodes_[idx][curr] = size(nodes_) - 1;
}
idx = nodes_[idx][curr];
}
}
int64_t query(int64_t num) {
if (size(nodes_) == 1) {
return -1;
}
int64_t result = 0, idx = 0;
for (int i = bit_length_ - 1; i >= 0; --i) {
int64_t curr = (num >> i) & 1;
if (nodes_[idx][1 ^ curr]) {
idx = nodes_[idx][1 ^ curr];
result |= 1ll << i;
} else {
idx = nodes_[idx][curr];
}
}
return result;
}
private:
const int bit_length_;
vector<array<int, 2>> nodes_;
};
public:
long long maxXor(int n, vector<vector<int>>& edges, vector<int>& values) {
vector<vector<int>> adj(size(values));
for (const auto& e : edges) {
adj[e[0]].emplace_back(e[1]);
adj[e[1]].emplace_back(e[0]);
}
vector<int64_t> lookup(size(values));
const function<int64_t(int, int)> dfs = [&](int u, int p) {
lookup[u] = values[u];
for (const auto& v : adj[u]) {
if (v == p) {
continue;
}
lookup[u] += dfs(v, u);
}
return lookup[u];
};
dfs(0, -1);
Trie trie(bit_length(lookup[0]));
const function<int64_t(int, int)> dfs2 = [&](int u, int p) {
int64_t result = max(trie.query(lookup[u]), static_cast<int64_t>(0));
for (const auto& v : adj[u]) {
if (v == p) {
continue;
}
result = max(result, dfs2(v, u));
}
trie.insert(lookup[u]);
return result;
};
return dfs2(0, -1);
}
private:
int bit_length(int64_t x) {
return x != 0 ? 64 - __builtin_clzll(x) : 1;
}
};
Beginner Explanation
What is Maximum XOR of Two Non-Overlapping Subtrees?
Maximum XOR of Two Non-Overlapping Subtrees (LeetCode #2479) is a Hard problem that primarily trains greedy.
How to think about it
- Restate the goal in your own words before coding.
- Work a tiny example by hand so the invariant becomes obvious.
- Identify the pattern — this problem aligns with dfs backtracking, trie, and greedy.
- Only then translate the idea into code.
Why this problem matters
Hard problems force you to combine patterns and prove complexity carefully — interview gold. Official solution notes mention: DFS, Trie, Greedy.
AlgoForge explanations are original teaching notes. Always open the official problem statement on LeetCode for constraints and examples.
Interview Walkthrough
Interview approach for Maximum XOR of Two Non-Overlapping Subtrees
Opening (30–60 seconds)
- Clarify inputs/outputs and edge cases (empty input, single element, duplicates, overflow).
- State a brute force so the interviewer knows you can solve it naively.
- Propose the optimal direction tied to dfs backtracking, trie, and greedy.
Core solution narrative
- Define the state you track (pointers, DP cell, set membership, stack top, etc.).
- Explain the transition when you process the next element.
- Call out time (O(nlogr)) and space (O(n)) before coding.
- Code cleanly; narrate variable names.
What interviewers listen for
- Correctness on edge cases
- Complexity honesty
- Ability to discuss trade-offs (e.g., hash map space vs. sort + two pointers)
Follow-up questions they may ask
- Can you solve it with less memory?
- What if the input stream is infinite / doesn't fit in RAM?
- How would tests look for adversarial inputs?
Optimized Approach
Optimized solution notes
The reference solutions on AlgoForge target O(nlogr) time and O(n) space.
Pattern focus: dfs backtracking, trie, and greedy
Use the pattern as a checklist:
- dfs backtracking — confirm the invariant holds after each step
- trie — confirm the invariant holds after each step
- greedy — confirm the invariant holds after each step
Multiple methods appear in the source solutions — compare them and explain when each is preferable.
Implementation tips
- Prefer readable names over micro-optimizations in interviews.
- Extract helpers only when they clarify (e.g., expand-around-center, DFS visit).
- After AC-level logic, re-scan for off-by-one and null checks.
Complexity Analysis
Complexity
| Measure | Bound |
|---|---|
| Time | O(nlogr) |
| Space | O(n) |
How to justify this in an interview
- Time: count loops, map/set operations, and recursive branching; state average vs worst case if relevant.
- Space: include hash maps, recursion stack, and output allocation when the problem asks for it.
If your implementation differs from the reference, re-derive big-O from your code — never memorize a complexity you cannot defend.
Common Mistakes
Common mistakes on Maximum XOR of Two Non-Overlapping Subtrees
- Skipping edge cases — empty collections, single-element inputs, max constraints.
- Wrong invariant for dfs backtracking, trie, and greedy — updating state too early or too late.
- Mutating input unexpectedly when the problem forbids it.
- Off-by-one in windows, ranges, or binary search bounds.
- Ignoring overflow / precision for integer arithmetic problems.
- Overengineering — jumping to an advanced structure when a simpler approach works.
Alternative Approaches
Alternatives
The source file includes more than one method. Compare:
- Primary optimized path — best complexity for typical interviews.
- Secondary approach — often brute force, sorting-based, or space-optimized variant.
Practice articulating when you would pick each (constraints, readability, follow-ups).
Edge Cases
Edge cases checklist
- Minimum input size
- Maximum input size / time limits
- Duplicates and already-sorted input
- Negative numbers / zeros (if applicable)
- Disconnected structures (graphs/trees)
- Single path vs branching recursion depth
Pattern Recognition
Spotting this pattern
Signal phrases that point to dfs backtracking, trie, and greedy:
- Sorted input or ability to sort without changing the answer class
- Need for contiguous subarray / substring → consider sliding window
- Need for O(1) membership → hash set/map
- Optimal substructure + overlapping subproblems → DP
- Connectivity / components → graph DFS/BFS or Union-Find
Primary topics: greedy.
Follow-up Interview Questions
Follow-ups
- How does the solution change if the input is a stream?
- Can you solve it in-place?
- What if duplicates must be handled differently?
- How would you parallelize the approach?
- Design tests that would break a buggy implementation.
Practice Recommendations
What to practice next
- Re-solve Maximum XOR of Two Non-Overlapping Subtrees in a second language (cpp, python).
- Drill 3–5 more problems tagged greedy.
- Teach the solution out loud in under 5 minutes.
- Add this problem to your revision calendar in 3 days and 14 days.
Visualization
Study checklist
- Read the official problem statement on LeetCode
- Solve on paper / whiteboard first
- Implement the dfs backtracking, trie, and greedy approach
- Verify edge cases from the checklist
- State time and space complexity aloud
- Compare with the AlgoForge reference solution
- Schedule a revision session
Revision notes
Maximum XOR of Two Non-Overlapping Subtrees (#2479) — Hard. Pattern: dfs backtracking, trie, and greedy. Complexity: O(nlogr) time / O(n) space. Re-derive the invariant before coding.
FAQs
What is the time complexity of Maximum XOR of Two Non-Overlapping Subtrees?+
The reference solutions aim for O(nlogr) time and O(n) space. Always re-derive complexity from the code you write in the interview.
What pattern does Maximum XOR of Two Non-Overlapping Subtrees use?+
It primarily maps to dfs backtracking, trie, and greedy, within the broader topic of greedy.
Is Maximum XOR of Two Non-Overlapping Subtrees good for interviews?+
Yes — as a Hard problem it is a solid practice target. Pair it with related problems in the same pattern family for spaced repetition.
Where can I read the official statement?+
Open the official LeetCode page for constraints and examples: https://leetcode.com/problems/maximum-xor-of-two-non-overlapping-subtrees/